Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Exclude R2RDump from source-build #1820

Closed
wants to merge 3 commits into from

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 20, 2020

This should remove the Microsoft.NETCore.CoreDisTools/1.0.1-prerelease-00005 prebuilt dependency.

Context at #1816 for why we can exclude R2RDump.

@dagood dagood self-assigned this Oct 20, 2020
@dagood
Copy link
Member Author

dagood commented Oct 21, 2020

Confirmed in local build that it's removed from production + tarball build.

<BaselineComparison>
  <Removed>
...
    <PackageIdentity Id="Microsoft.NETCore.CoreDisTools" Version="1.0.1-prerelease-00005" />
...
    <PackageIdentity Id="runtime.placeholder-rid.Microsoft.NETCore.CoreDisTools" Version="1.0.1-prerelease-00005" />
...
  </Removed>
</BaselineComparison>

Forgot to make the change to the baselines to verify this in PR validation, but I'm going to avoid making that change here so I don't reset CI. (Unless I also need to make some other change.)

@dagood dagood requested review from crummel and dseefeld October 21, 2020 21:09
@dseefeld
Copy link
Contributor

@dagood Can this be closed in favor of #1822?

@dagood
Copy link
Member Author

dagood commented Oct 22, 2020

Yep, this package shows up as removed in the prebuilt data for #1822.

@dagood dagood closed this Oct 22, 2020
@dagood dagood deleted the rm-r2rdump branch October 22, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants