Add a doc describing how to add new RIDs to source-build #2103
Conversation
Anyone else adding their Linux distribution's RID to source-build might find this useful. I am trying to get this out of my head and into a shape where others can make use of this. See: dotnet#2095
|
cc @crummel |
dotnet-issue-labeler
bot
added
the
area-additional-repos
| Then build with the `/p:UpdateRuntimeFiles=true` flag: | ||
|
|
||
| ``` | ||
| ./build.sh /p:UpdateRuntimeFiles=true |
There was a problem hiding this comment.
Maybe this should be
./build.sh -- /p:UpdateRuntimeFiles=true
There was a problem hiding this comment.
In the dotnet/runtime release/5.0 branch, ./build.sh --help says:
...
Command line arguments starting with '/p:' are passed through to MSBuild.
...
Have you run into any cases where -- was required?
There was a problem hiding this comment.
Defenitly yes
dotnet-v5.0.104-SDK$ ./build.sh --help
usage: ./build.sh [options]
options:
--with-ref-packages <dir> use the specified directory of reference packages
--with-packages <dir> use the specified directory of previously-built packages
--with-sdk <dir> use the SDK in the specified directory for bootstrapping
use -- to send the remaining arguments to MSBuild
dotnet-v5.0.104-SDK$ ./build.sh --with-sdk ../bootstrap/.dotnet /p:UpdateRuntimeFiles=true
Unrecognized argument '/p:UpdateRuntimeFiles=true'
usage: ./build.sh [options]
options:
--with-ref-packages <dir> use the specified directory of reference packages
--with-packages <dir> use the specified directory of previously-built packages
--with-sdk <dir> use the SDK in the specified directory for bootstrapping
use -- to send the remaining arguments to MSBuild
There was a problem hiding this comment.
Hm. I think we might be talking about different things.
I think you are looking at source-build's support/tarball/build.sh (which becomes ./build.sh when you create the tarball). That needs -- to separate normal arguments from msbuild arguments.
The step here is for passing the /p:UpdateRuntimeFiles flag to dotnet/runtime's build.sh, which doesn't need that: https://github.com/dotnet/runtime/blob/fb2db274ae16120b16c64167cc00538b2acaf155/eng/common/build.sh#L40
Do you know where I could have made that clearer in this doc?
There was a problem hiding this comment.
May be after "1. Grab the source code" add something like "(Not this repository) because I completly miss it :(
There was a problem hiding this comment.
Thanks! Does the new commit make it clearer?
It's not for source-build.
Co-authored-by: Chris Rummel <crummel@microsoft.com>
Anyone else adding their Linux distribution's RID to source-build might find this useful.
I am trying to get this out of my head and into a shape where others can make use of this.
See: #2095