-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/2.1] 2.1.1 fixes, combined #610
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.1.300-rc1-008673 | ||
2.1.300 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
https://dotnetfeed.blob.core.windows.net/orchestrated-release-2-1/20180515-07/final/index.json | ||
https://dotnetfeed.blob.core.windows.net/orchestrated-release-2-1/20180605-09/final/index.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
patches/cli/0001-Persist-ASP.NET-runtime-patch-targeting-default.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
From 9609106bcab766e1e44e464c38cc4148ea639a23 Mon Sep 17 00:00:00 2001 | ||
From: Davis Goodin <dagood@microsoft.com> | ||
Date: Wed, 13 Jun 2018 09:46:43 -0500 | ||
Subject: [PATCH] Persist ASP.NET runtime patch targeting default | ||
|
||
Let the CLI build take a default value for TargetLatestAspNetCoreRuntimePatch in the output SDK. | ||
|
||
https://github.com/dotnet/cli/issues/9469 is required to remove this patch. | ||
--- | ||
build/MSBuildExtensions.targets | 3 +++ | ||
1 file changed, 3 insertions(+) | ||
|
||
diff --git a/build/MSBuildExtensions.targets b/build/MSBuildExtensions.targets | ||
index 042cd2e93..7df11b659 100644 | ||
--- a/build/MSBuildExtensions.targets | ||
+++ b/build/MSBuildExtensions.targets | ||
@@ -185,6 +185,9 @@ Copyright (c) .NET Foundation. All rights reserved. | ||
<LatestPatchVersionForNetCore1_0 Condition="'$(LatestPatchVersionForNetCore1_0)' == ''">1.0.11</LatestPatchVersionForNetCore1_0> | ||
<LatestPatchVersionForNetCore1_1 Condition="'$(LatestPatchVersionForNetCore1_1)' == ''">1.1.8</LatestPatchVersionForNetCore1_1> | ||
<LatestPatchVersionForNetCore2_0 Condition="'$(LatestPatchVersionForNetCore2_0)' == ''">2.0.7</LatestPatchVersionForNetCore2_0> | ||
+ | ||
+ <!-- If true, always target the latest ASP.NET Core runtime by default --> | ||
+ <TargetLatestAspNetCoreRuntimePatch Condition="'$(TargetLatestAspNetCoreRuntimePatch)' == ''">$(DefaultTargetLatestAspNetCoreRuntimePatch)</TargetLatestAspNetCoreRuntimePatch> | ||
</PropertyGroup> | ||
</Project> | ||
]]> | ||
-- | ||
2.17.1.windows.2 | ||
|
47 changes: 47 additions & 0 deletions
47
patches/websdk/0001-Add-versioned-AspNetCore-patch-override-properties.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
From d5f8588d6a97ba9972e572219c2a1a714fd587b1 Mon Sep 17 00:00:00 2001 | ||
From: Davis Goodin <dagood@microsoft.com> | ||
Date: Wed, 13 Jun 2018 12:35:52 -0500 | ||
Subject: [PATCH] Add versioned AspNetCore patch override properties | ||
|
||
https://github.com/aspnet/websdk/issues/355 will include changes that make this patch unnecessary. | ||
--- | ||
.../Sdk.DefaultItems.targets | 10 ++++++---- | ||
1 file changed, 6 insertions(+), 4 deletions(-) | ||
|
||
diff --git a/src/Web/Microsoft.NET.Sdk.Web.Targets/Sdk.DefaultItems.targets b/src/Web/Microsoft.NET.Sdk.Web.Targets/Sdk.DefaultItems.targets | ||
index 9fc331e..15ebdc5 100644 | ||
--- a/src/Web/Microsoft.NET.Sdk.Web.Targets/Sdk.DefaultItems.targets | ||
+++ b/src/Web/Microsoft.NET.Sdk.Web.Targets/Sdk.DefaultItems.targets | ||
@@ -67,11 +67,12 @@ Copyright (c) .NET Foundation. All rights reserved. | ||
<!-- Latest patch version of .All Framework --> | ||
<PropertyGroup Condition="'$(LatestAspNetCoreAllPatchVersion)' == ''"> | ||
<!-- Placeholder for setting latest patch version using the bundled version from CLI for previous TFMs, this will not apply until 2.2 --> | ||
- <!-- <LatestAspNetCoreAllPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.1'">$(LatestPatchVersionForAspNetCoreAll2_1)</LatestAspNetCoreAllPatchVersion> --> | ||
+ <LatestAspNetCoreAllPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.1'">$(LatestPatchVersionForAspNetCoreAll2_1)</LatestAspNetCoreAllPatchVersion> | ||
+ <LatestAspNetCoreAllPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.2'">$(LatestPatchVersionForAspNetCoreAll2_2)</LatestAspNetCoreAllPatchVersion> | ||
|
||
<!-- If targeting the same release that is bundled with the .NET Core SDK, use the bundled package version | ||
provided by Microsoft.NETCoreSdk.BundledVersions.props --> | ||
- <LatestAspNetCoreAllPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '$(BundledAspNetCoreAllTargetFrameworkVersion)'">$(BundledAspNetCoreAllPackageVersion)</LatestAspNetCoreAllPatchVersion> | ||
+ <LatestAspNetCoreAllPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '$(BundledAspNetCoreAllTargetFrameworkVersion)' AND '$(LatestAspNetCoreAllPatchVersion)' == ''">$(BundledAspNetCoreAllPackageVersion)</LatestAspNetCoreAllPatchVersion> | ||
<!-- If not covered by the previous cases use the target framework version for the latest patch version --> | ||
<LatestAspNetCoreAllPatchVersion Condition="'$(LatestAspNetCoreAllPatchVersion)' == ''">$(_TargetFrameworkVersionWithoutV)</LatestAspNetCoreAllPatchVersion> | ||
</PropertyGroup> | ||
@@ -79,11 +80,12 @@ Copyright (c) .NET Foundation. All rights reserved. | ||
<!-- Latest patch version of .App Framework --> | ||
<PropertyGroup Condition="'$(LatestAspNetCoreAppPatchVersion)' == ''"> | ||
<!-- Placeholder for setting latest patch version using the bundled version from CLI for previous TFMs, this will not apply until 2.2 --> | ||
- <!-- <LatestAspNetCoreAppPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.1'">$(LatestPatchVersionForAspNetCoreApp2_1)</LatestAspNetCoreAppPatchVersion> --> | ||
+ <LatestAspNetCoreAppPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.1'">$(LatestPatchVersionForAspNetCoreApp2_1)</LatestAspNetCoreAppPatchVersion> | ||
+ <LatestAspNetCoreAppPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '2.2'">$(LatestPatchVersionForAspNetCoreApp2_2)</LatestAspNetCoreAppPatchVersion> | ||
|
||
<!-- If targeting the same release that is bundled with the .NET Core SDK, use the bundled package version | ||
provided by Microsoft.NETCoreSdk.BundledVersions.props --> | ||
- <LatestAspNetCoreAppPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '$(BundledAspNetCoreAppTargetFrameworkVersion)'">$(BundledAspNetCoreAppPackageVersion)</LatestAspNetCoreAppPatchVersion> | ||
+ <LatestAspNetCoreAppPatchVersion Condition="'$(_TargetFrameworkVersionWithoutV)' == '$(BundledAspNetCoreAppTargetFrameworkVersion)' AND '$(LatestAspNetCoreAppPatchVersion)' == ''">$(BundledAspNetCoreAppPackageVersion)</LatestAspNetCoreAppPatchVersion> | ||
<!-- If not covered by the previous cases use the target framework version for the latest patch version --> | ||
<LatestAspNetCoreAppPatchVersion Condition="'$(LatestAspNetCoreAppPatchVersion)' == ''">$(_TargetFrameworkVersionWithoutV)</LatestAspNetCoreAppPatchVersion> | ||
</PropertyGroup> | ||
-- | ||
2.17.1.windows.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule sdk
updated
5 files
+2 −2 | build/Versions.props | |
+2 −1 | build/build.sh | |
+13 −11 | build/uploadperftobenchview.cmd | |
+110 −0 | build/uploadperftobenchview.sh | |
+75 −2 | perf.groovy |
Submodule websdk
updated
from 8a0016 to 8803ff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch isn't fully working yet (see #586 (comment)) so I'm going to go ahead and merge #598 since its CI finished and rebase this PR with the fix.