-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up sourcelink repo and remove workarounds #1003
Conversation
1. Remove license headers from non-shipping assets (project files) 2. Use the Microsoft.Build.NoTargets SDK for content-only packages That avoids invoking the compiler without defining custom targets and makes the repository use the same path as other repositories in the stack. 3. Delete runtimeconfig.template.json in favor of the in-built "<RollForward>...</RollForward>" switch. 4. Remove not needed sourcebuild target. 5. Group dependencies in Versions.props by repositories. Remove the now unneeded Microsoft.NET.Test.Sdk entry. 6. Define target frameworks for source build centrally in one place. 7. Remove unnecessary package dependencies from projects. 8. Apply code styling: - "empty line after Project tag and before closing Project tag" - "empty line between groups (property, item, target)" - "TargetFramework(s) should be the first property in the project" 9. Remove unnecessary PrivateAssets="all" attributes from four ProjectReference items.
Does "..." refer to the RollForward property here?
|
Yes. Markdown didn't display that correctly on GH. Fixed the comment, thanks. |
<Target Name="GetRepoSourceBuildCommandConfiguration" | ||
BeforeTargets="GetSourceBuildCommandConfiguration"> | ||
<PropertyGroup> | ||
<InnerBuildArgs>$(InnerBuildArgs) /p:Pack=true</InnerBuildArgs> | ||
</PropertyGroup> | ||
</Target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that this is no longer needed. Sourcebuild automatically creates packages.
<!-- TODO: Remove when Arcade offers an in-built way to filter out anything other than NetCurrent. --> | ||
<PropertyGroup> | ||
<TargetFrameworks Condition="'$(TargetFrameworks)' != '' and '$(DotNetBuildFromSource)' == 'true'">$(NetCurrent)</TargetFrameworks> | ||
</PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mmitche
Yes, those entries aren't required by msbuild anymore: dotnet/corefx#35686 (comment) We removed them from corefx (now dotnet/runtime) 4 years ago and didn't encounter any issues with tooling. Our samples don't include them either:
|
@tmat soft ping since this PR has been open for around a week and is required for the pre-built detection work. Would be great if you could take a look at it / approve it whenever you have time. Thanks! |
@tmat and I chatted offline and he wants me to move the formatting changes into a separate commit or PR. Will do soon. |
Closing in favor of #1015 |
Remove license headers from non-shipping assets (project files)Remove unnecessary license header in msbuild #1014"<RollForward>...</RollForward>"
switch.