Add CompileBefore to Git untracked files consideration #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
requested changes
Feb 26, 2024
|
We will manage this in the F# repo.: |
|
We will manage this issue here: dotnet/fsharp#16771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetEmbeddedFilesFromSourceControlManagerUntrackedFilesonly considers files if they're in@(Compile). In an F# project,TargetFrameworkMonikerAssemblyAttributesPathis not in@(Compile)but is instead in@CompileBefore. The result is that the F# compiler never even attempts to embedobj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.fs(for example), because it was never added to@(EmbeddedFiles).It's possible that the correct fix is instead in Microsoft.FSharp.Targets. The behaviour of adding to
CompileBeforerather than toCompilewas added in dotnet/fsharp@01c621c, which is extremely vague and dates back before pull requests and GitHub were a thing; so I can't find any of the context for it.