-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IdentityServer from angular template #144
Conversation
- Use default Identity UI Razor Pages with cookies instead
src/content/Angular-CSharp/ClientApp/src/app/nav-menu/nav-menu.component.html
Show resolved
Hide resolved
src/content/Angular-CSharp/ClientApp/src/app/fetch-data/fetch-data.component.ts
Outdated
Show resolved
Hide resolved
src/content/Angular-CSharp/ClientApp/src/app/fetch-data/fetch-data.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @halter73!
I'll let the experts review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. There are some open questions and changes/regressions in the user experience that are worth talking about:
- Is there no way to know when you are authenticated or not? Isn't it confusing that you log in, come back to the app, and you see no visual change?
- What happens with all the state the app has before we redirect? Do we throw it all out?
- Why are we removing the authorize guard? That's meant to ensure you are authenticated when you access some areas of the page.
- How do you log out in the template?
- Where are we wiring up Antiforgery?
Nope. Currently the best we can do with just cookie auth and the default Identity UI is detect the redirect. Later, MapIdentityApi will provide a way to detect this which we will provide samples for. Eventually it would be nice to update these project templates to use it and not use the default Identity UI razor pages at all, but it's not ready yet.
Yes.
Because we have no way to know if we're authenticated or not.
You click the "Account" link in the nav bar. And then click "Logout" on the /Identity/Account/Manage page.
It's not explicit. This is just the default Identity UI razor pages. I can confirm that the __RequestVerificationToken is rendered though. |
Contributes to dotnet/aspnetcore#47226