This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add support for Index and Range #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrajobst
added
netstandard-api
marek-safar
reviewed
Dec 17, 2018
terrajobst
force-pushed
the
index-range
branch
from
eb7997f to
8924de9
Compare
terrajobst
removed
the
* NO MERGE *
terrajobst
changed the title
|
The changes LGTM. |
tarekgh
approved these changes
Feb 21, 2019
|
Since the PR is now up-to-date, @dotnet/nsboard-foundation @dotnet/nsboard-platform @dotnet/nsboard-tooling @dotnet/nsboard-unity PTAL. |
marek-safar
approved these changes
Feb 21, 2019
jaredpar
approved these changes
Feb 21, 2019
clairernovotny
approved these changes
Feb 22, 2019
stephentoub
reviewed
Feb 22, 2019
stephentoub
approved these changes
Feb 22, 2019
terrajobst
force-pushed
the
index-range
branch
from
8924de9 to
9483547
Compare
|
@dotnet/nsboard-unity, sorry for not waiting for sign-off, but I'd like to get this in before ask mode closes for the upcoming preview. Please let me know if there are any concerns, we can address this in the next preview. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the basic APIs for
IndexandRange. However, it misses most of the companion APIs because they don't even exist in CoreFx yet. The work is tracked in https://github.com/dotnet/corefx/issues/34076. Once done, I'll update the PR to reflect the final API shape.This PR now reflects the current state for CoreFX.
@tarekgh, please take a look to make sure nothing looks weird.