Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the HTTPS server variables as lower case since .NET Framework expects this #126

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Set the HTTPS server variables as lower case since .NET Framework expects this #126

merged 2 commits into from
Jul 22, 2022

Conversation

ragnarstolsmark
Copy link
Contributor

@ragnarstolsmark ragnarstolsmark commented Jul 22, 2022 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Set the HTTPS server variables as lower case since .NET Framework expects this

PR Description
System.Web.WorkerRequest checks if the HTTPS server variable equals "on" to determine if a request IsSecure. This check is case sensitive. When this check fails the Request.Url is returned without https.
https://referencesource.microsoft.com/#System.Web/Hosting/IIS7WorkerRequest.cs,abb2c5b4bea0c0aa

Addresses #125

@ragnarstolsmark
Set the HTTPS server variables as lower case
7b0b32a 
System.Web.WorkerRequest checks if the HTTPS server variable equals "on" to determine if a request IsSecure. This check is case sensitive. When this check fails the Request.Url is returned without https.
https://referencesource.microsoft.com/#System.Web/WorkerRequest.cs,620f7ba656959388
@dnfadmin
Copy link

dnfadmin commented Jul 22, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

twsouthwick
twsouthwick approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Microsoft.AspNetCore.SystemWebAdapters/Adapters/ProxyHeaderModule.Framework.cs Show resolved Hide resolved
@twsouthwick twsouthwick enabled auto-merge (squash) July 22, 2022 18:49
@twsouthwick twsouthwick merged commit 3c99c6d into dotnet:main Jul 22, 2022
@twsouthwick twsouthwick mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twsouthwick twsouthwick twsouthwick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragnarstolsmark @dnfadmin @twsouthwick