-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relayer packages to remove dependencies for adapters #134
Conversation
54e30cb
to
e8eaaf7
Compare
This change separates out the System.Web types into a single assembly that doesn't have any reliance on other dependencies. Any additional dependencies will be brought in by the extensions library which will only need to be added to the ASP.NET Core and ASP.NET Framework applications themselves (not any supporting libraries).
8d1eb1a
to
713219e
Compare
@davidfowl @Tratcher @mjrousos I've updated the PR per our discussion this morning. There are a few types I'm including in the adapters libraries so they can potentially be used for 3rd party libraries (i.e. MessagePack support for session keys):
The following are public APIs that are shared services. As discussed, I'm using shared sources and they do not make sense in the adapter layer:
I don't think we want to have same type names but not actually same types in two assemblies, so these need to be renamed or shared in a 4th package (i.e. |
When this ships we'll want to obsolete the old packages on nuget. |
(not relevant after dotnet#134)
This change separates out the System.Web types into a single assembly that doesn't have any reliance on other dependencies. Any additional dependencies will be brought in by the extensions library which will only need to be added to the ASP.NET Core and ASP.NET Framework applications themselves (not any supporting libraries).
Fixes #131