Expose extension methods to wrap and unwrap adapters #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidfowl Here are the extension methods. I'm not happy with the name, though, as it feels fairly generic (but maybe sufficient?). |
davidfowl
reviewed
Jun 8, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/SystemWebAdapterExtensions.cs
Outdated
Show resolved
Hide resolved
Tratcher
requested changes
Oct 27, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/SystemWebAdaptersConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/SystemWebAdaptersConversionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/SystemWebAdaptersConversionExtensions.cs
Outdated
Show resolved
Hide resolved
Tratcher
reviewed
Oct 31, 2023
Comment on lines
78
to
85
| public static HttpResponseCore AsAspNetCore(this HttpResponse response) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(response); | ||
|
|
||
| return response; | ||
| } | ||
|
|
||
| internal static HttpContextBase AsSystemWebBase(this HttpContextCore context) |
There was a problem hiding this comment.
Nit: Can you put the AsAspNetCore ones first so that the AsSystemWeb ones can be together, even if the last one is internal?
Tratcher
approved these changes
Oct 31, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/FeatureCollectionExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, we only support using casting to convert between the two representations. This change exposes the extension methods we are using internally to expose the ASP.NET Core or System.Web objects.
Fixes dotnet/aspnetcore#51119