fix for bug #1373 #1375
Merged
fix for bug #1373 #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlorbetske
approved these changes
Dec 21, 2017
mlorbetske
reviewed
Dec 21, 2017
|
|
||
| if (languagesForMatches.Count > 1) | ||
| { | ||
| // there are multiple languages in the possible templates. No way to decide which one to use. |
There was a problem hiding this comment.
This isn't strictly true is it? Couldn't precedence disambiguate (if one language of the template were preferred by the author over the others)?
There was a problem hiding this comment.
Up to now, we've only considered precedence among templates with the same group identity and language. I could add a check here so that if:
- all candidate templates are the same group identity
- user didn't specify a language
Then don't do the language check. These cases would fall through to the remaining existing checks, the last one being: take the highest precedence template if they're all the same group identity.
The check would change the new if at line 116 to be:
if (_hasUserInputLanguage || _TemplateListResolver..AreAllTemplatesSameGroupIdentity(_coreMatchedTemplates))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the only template match group doesn't have the default language, and no user language is input, then the template will still be chosen as long as the group only contains templates in one language.