do not enable nullable on netstandard2.0 #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
force-pushed
the
do-not-turn-on-nullable-for-netstandard
branch
from
7771e31
to
6e6a85d
Compare
jmarolf
force-pushed
the
do-not-turn-on-nullable-for-netstandard
branch
from
52eb405
to
6e6a85d
Compare
vlada-shubina
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
@jmarolf thanks, looks good.
I will push couple other tests shortly.
Preview 6 is already in approval mode - will you request approval or should I?
dsplaisted
approved these changes
Jun 18, 2021
vlada-shubina
added
the
servicing-consider
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3297