Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet/templating#3360 using file-scoped namespaces in classlib template #3395

Merged

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Jul 6, 2021

Problem

#3360 using file-scoped namespaces

Solution

Added using of file-scoped namespaces in classlib template

@vlada-shubina vlada-shubina force-pushed the classlib-file-scoped-namespaces branch from f972f5d to 4744494 Compare July 7, 2021 09:41
@vlada-shubina vlada-shubina force-pushed the classlib-file-scoped-namespaces branch 2 times, most recently from f9d81ea to b740a75 Compare July 13, 2021 12:08
@vlada-shubina vlada-shubina added do-not-merge The PR should not be merged until impediments are resolved. need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases labels Jul 13, 2021
@DamianEdwards
Copy link
Member

Note this comment RE the compiler feature to enable file-scoped namespaces. In short, it wasn't flowing properly but is now.

@vlada-shubina vlada-shubina force-pushed the classlib-file-scoped-namespaces branch from b740a75 to 7a0ccb9 Compare July 14, 2021 09:17
@vlada-shubina vlada-shubina removed the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Jul 14, 2021
@DamianEdwards
Copy link
Member

The compiler with support for this is now in SDK version 6.0.100-preview.7.21364.4

@vlada-shubina vlada-shubina force-pushed the classlib-file-scoped-namespaces branch 5 times, most recently from 67518e8 to 057aace Compare July 15, 2021 14:11
@vlada-shubina vlada-shubina force-pushed the classlib-file-scoped-namespaces branch from 057aace to a0cd862 Compare July 15, 2021 17:06
@vlada-shubina vlada-shubina removed the do-not-merge The PR should not be merged until impediments are resolved. label Jul 15, 2021
@vlada-shubina vlada-shubina merged commit 8a143e4 into dotnet:main Jul 15, 2021
@vlada-shubina vlada-shubina deleted the classlib-file-scoped-namespaces branch July 15, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants