Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed app template, moved changes to console app instead #3424

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Jul 9, 2021

Problem

#3423
#3344

Solution

removed app template, moved changes to console app instead
removed using System; to use global usings instead for classlib and console
more tests

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner July 9, 2021 10:42
@vlada-shubina vlada-shubina added the do-not-merge The PR should not be merged until impediments are resolved. label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge The PR should not be merged until impediments are resolved. need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants