Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on reading host data are promoted to warning level #3655

Merged

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Aug 16, 2021

Problem

fixes #3627

Solution

  • log errors as warnings
  • localize text
  • removed useless logging
  • removed showing exception stack trace on error/warning logging
  • fallback to reading host data from file if data in cache is incorrect
  • tests

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner August 16, 2021 11:45
@vlada-shubina vlada-shubina force-pushed the fix-log-level-for-host-data-error branch from 6fb653f to 1bcc45c Compare August 16, 2021 11:46
@vlada-shubina vlada-shubina force-pushed the fix-log-level-for-host-data-error branch from 1bcc45c to e7c11f2 Compare August 16, 2021 12:00
@vlada-shubina vlada-shubina merged commit bbd9bf7 into dotnet:main Aug 17, 2021
@vlada-shubina vlada-shubina deleted the fix-log-level-for-host-data-error branch August 17, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output "Failed to load host data for template" to Error and not Verbose level logging
2 participants