-
Notifications
You must be signed in to change notification settings - Fork 390
OS constraint implementation #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@baronfel @JanKrivanek looking for the feedback here: do we need to have more features here?
As of now only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I have no insight and understanding of Maui use cases and requirements for our constraints feature. But I'm worried whether this implementation can fullfill them
98782ea
to
9196815
Compare
Agree with the OperatingSystem-based approach. We don't need to handle OS versions, there's no concrete use case for that that I can see. I'd just make sure that case-insensitive comparisons are handled and then this is good to go IMO! |
9196815
to
4fec0fa
Compare
Opening for final review, now targeting main. I decided to stay with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Problem
#3107 - OS constraint
Checks:
#nullable enable
to all the modified files ?