Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -svc pools for release/ branches #5563

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Use -svc pools for release/ branches #5563

merged 1 commit into from
Nov 7, 2022

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Nov 4, 2022

Problem

For billing purposes, we need to use the "-Svc-" named pools for release branches

Solution

Flip over to using -Svc pools in these builds

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@MattGal MattGal self-assigned this Nov 4, 2022
@MattGal MattGal mentioned this pull request Nov 4, 2022
Closed
31 tasks
@vlada-shubina vlada-shubina merged commit a10f061 into release/3.1 Nov 7, 2022
@vlada-shubina vlada-shubina deleted the use-svc-pools-release/3.1 branch November 23, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlada-shubina vlada-shubina vlada-shubina approved these changes

@JanKrivanek JanKrivanek JanKrivanek approved these changes

@vseanreesermsft vseanreesermsft Awaiting requested review from vseanreesermsft

Assignees

@MattGal MattGal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattGal @JanKrivanek @vlada-shubina