Force assign callerFilePath #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/VerificationEngine.cs
Show resolved
Hide resolved
|
/backport to release/7.0.2xx |
|
Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3697001866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5710
Issue rootcause discovered when working on: VerifyTests/Verify#729
When usage of Veriy built on one OS and then called from other - the default implementation of
VerifySettings.DerivePathInfothen leads toArgumentNullException- as parsing paths withPathutility returns empty/null for paths from other platform.This can be accidentaly remediated by passing custom
DerivePathInfo. That's static - so it can happen to be injected by unrelated test in CI (that was the reason for randomness).Solution
Explicitly inject
callerFilePathtoVerify. Pass through path obtained from the external caller of our API - so that path originates from the same build where the verification functionality is invoked.Checks:
#nullable enableto all the modified files ?