Add PreferDefaultName property

[maridematte]

Problem

This is for Issue 2303.

Solution

Adding support for PreferDefaultName optional property in template.json. The property defines which name should be used as a fallback option when the -name option is not passed in template creation.

• If true the engine will use the DefaultName of the template.
• If false the engine will use the folder's name.

Checks:

• Added unit tests
• Added #nullable enable to all the modified files ?

[dnfadmin]

All CLA requirements met.

[JanKrivanek]

Looks good!

Tests will be needed - you can add them to TemplateCreatorTests. (after #5677 is merged, it'll be possible to add snapshot tests as well - but for now best option is TemplateCreatorTests or IDE.IntegrationTests)

[vlada-shubina]

Looks very good, great work! Left couple of comments inline.

The following bits are missing:

• add new field to JSON schema: https://github.com/dotnet/templating/blob/main/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Schemas/JSON/template.json (and preferably test)
• updating documentation: https://github.com/dotnet/templating/blob/main/docs/Reference-for-template.json.md#output-management
• tests (unit and integration)

[vlada-shubina]

Looks good!

Couple of comments and suggestions for additional tests.

Could you please investigate behavior: what is the error in this case: no defaultName is specified and preferDefaultName is set to true? Maybe consider End2End test.

[JanKrivanek]

Looks solid to me - good job!

I added few comments o consider for making test code more conscise.
You can probably as well use templates test FW (via passing explicit null as name parameter).
After this is merged please create PR in schemastore to reflect your changes there as well - https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/template.json

Overall it's great!!

[vlada-shubina]

Thanks, looks good to go.
Just a small casing issue in the error message

[vlada-shubina]

/backport to release/7.0.2xx

[github-actions]

Started backporting to release/7.0.2xx: https://github.com/dotnet/templating/actions/runs/3947472630

[github-actions]

@vlada-shubina backporting to release/7.0.2xx failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Base of PreferDefaultName
Using index info to reconstruct a base tree...
M	src/Microsoft.TemplateEngine.Abstractions/PublicAPI.Unshipped.txt
M	src/Microsoft.TemplateEngine.Edge/PublicAPI.Unshipped.txt
M	src/Microsoft.TemplateEngine.Edge/Settings/TemplateInfo.cs
M	src/Microsoft.TemplateEngine.Edge/Template/TemplateCreator.cs
M	src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ConfigModel/TemplateConfigModel.cs
M	src/Microsoft.TemplateSearch.Common/TemplateDiscoveryMetadata/BlobStorageTemplateInfo.cs
M	test/Microsoft.TemplateEngine.Mocks/MockTemplateInfo.cs
Falling back to patching base and 3-way merge...
Auto-merging test/Microsoft.TemplateEngine.Mocks/MockTemplateInfo.cs
Auto-merging src/Microsoft.TemplateSearch.Common/TemplateDiscoveryMetadata/BlobStorageTemplateInfo.cs
Auto-merging src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ConfigModel/TemplateConfigModel.cs
Auto-merging src/Microsoft.TemplateEngine.Edge/Template/TemplateCreator.cs
Auto-merging src/Microsoft.TemplateEngine.Edge/Settings/TemplateInfo.cs
Auto-merging src/Microsoft.TemplateEngine.Edge/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Microsoft.TemplateEngine.Edge/PublicAPI.Unshipped.txt
Auto-merging src/Microsoft.TemplateEngine.Abstractions/PublicAPI.Unshipped.txt
CONFLICT (content): Merge conflict in src/Microsoft.TemplateEngine.Abstractions/PublicAPI.Unshipped.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Base of PreferDefaultName
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@vlada-shubina an error occurred while backporting to release/7.0.2xx, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.