Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate CLI command #5839

Merged

Conversation

vlada-shubina
Copy link
Member

@vlada-shubina vlada-shubina commented Dec 28, 2022

Problem

template validation

Solution

follow up for #5838
usage of new validation from CLI authoring tools

TODO:

  • extract localization strings (once the approach is approved)

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@vlada-shubina vlada-shubina requested a review from a team as a code owner December 28, 2022 12:18
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do we want to localize the validation command later on?

@vlada-shubina vlada-shubina changed the base branch from dev/vshubina/validation-poc to feature/validation March 14, 2023 16:11
@vlada-shubina vlada-shubina force-pushed the validation-cli-tool branch 2 times, most recently from 31881c1 to 029e493 Compare March 14, 2023 19:18
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vlada-shubina vlada-shubina merged commit f283dae into dotnet:feature/validation Mar 15, 2023
vlada-shubina added a commit that referenced this pull request Mar 15, 2023
* validate CLI command

* review comments

* localization

* test fix
vlada-shubina added a commit that referenced this pull request Mar 17, 2023
* validate CLI command

* review comments

* localization

* test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants