-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate
CLI command
#5839
Merged
vlada-shubina
merged 4 commits into
dotnet:feature/validation
from
vlada-shubina:validation-cli-tool
Mar 15, 2023
Merged
validate
CLI command
#5839
vlada-shubina
merged 4 commits into
dotnet:feature/validation
from
vlada-shubina:validation-cli-tool
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Do we want to localize the validation command later on?
tools/Microsoft.TemplateEngine.Authoring.CLI/Commands/validate/ValidateCommand.cs
Outdated
Show resolved
Hide resolved
tools/Microsoft.TemplateEngine.Authoring.CLI/Commands/validate/ValidateCommand.cs
Outdated
Show resolved
Hide resolved
tools/Microsoft.TemplateEngine.Authoring.CLI/Commands/validate/ValidateCommand.cs
Show resolved
Hide resolved
...uthoring.CLI.IntegrationTests/Microsoft.TemplateEngine.Authoring.CLI.IntegrationTests.csproj
Show resolved
Hide resolved
vlada-shubina
changed the base branch from
dev/vshubina/validation-poc
to
feature/validation
March 14, 2023 16:11
vlada-shubina
force-pushed
the
validation-cli-tool
branch
from
March 14, 2023 16:15
b89694b
to
5c38c4a
Compare
vlada-shubina
force-pushed
the
validation-cli-tool
branch
2 times, most recently
from
March 14, 2023 19:18
31881c1
to
029e493
Compare
vlada-shubina
force-pushed
the
validation-cli-tool
branch
from
March 14, 2023 19:44
029e493
to
715f6e1
Compare
YuliiaKovalova
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
vlada-shubina
added a commit
that referenced
this pull request
Mar 15, 2023
* validate CLI command * review comments * localization * test fix
vlada-shubina
added a commit
that referenced
this pull request
Mar 17, 2023
* validate CLI command * review comments * localization * test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
template validation
Solution
follow up for #5838
usage of new validation from CLI authoring tools
TODO:
Checks:
#nullable enable
to all the modified files ?