Remove live runtime dependencies #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... use the shared framework that comes with the SDK instead. We determined that a live runtime doesn't provide much benefit anymore and in contrast often causes pain when flowing dependencies to dotnet/sdk.
akoeplinger
approved these changes
Jun 19, 2024
|
Removed additional args from the YAML |
|
Cool. So you are OK with this @mmitche and @marcpopMSFT? |
mmitche
approved these changes
Jun 19, 2024
|
We had the live runtime flow for testing purposes IIRC - I guess this need was largely removed when the |
This was my thinking as well. I think there is some marginal benefit but it's not significantly different than any of the other tooling repos (ie we might catch something in the runtime because of how the tooling is implemented but because of limitations in our build system, better to just add a test to the sdk repo if we need coverage). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... use the shared framework that comes with the
SDK instead.
We determined that a live runtime doesn't provide
much benefit anymore and in contrast often
causes pain when flowing dependencies to
dotnet/sdk.
Note: The VMR should react to this when the change reaches dotnet/sdk. This line should be removed: https://github.com/dotnet/sdk/blob/a5ccfef7bea1d8883142ffa632439ca848da9378/src/SourceBuild/content/repo-projects/templating.proj#L12