In default case, only fail if there are project type guids

dotnet · May 1, 2020 · 462a99c · 462a99c
1 parent bdac5e8
commit 462a99c
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/MSBuild.Abstractions/MSBuildWorkspace.cs b/src/MSBuild.Abstractions/MSBuildWorkspace.cs
@@ -258,11 +258,18 @@ private bool IsSupportedProjectType(MSBuildProjectRootElement root)
                     return true;
                 case ProjectSupportType.Unsupported:
                 default:
-                    var allSupportedProjectTypeGuids = DesktopFacts.KnownSupportedDesktopProjectTypeGuids.Select(ptg => ptg.ToString());
-                    var allReadProjectTypeGuids = MSBuildHelpers.GetAllProjectTypeGuids(root);
-                    Console.WriteLine($"{root.FullPath} is an unsupported project type. Not all project type guids are supported.");
-                    PrintGuidMessage(allSupportedProjectTypeGuids, allReadProjectTypeGuids);
-                    return false;
+                    if (MSBuildHelpers.HasProjectTypeGuidsNode(root))
+                    {
+                        var allSupportedProjectTypeGuids = DesktopFacts.KnownSupportedDesktopProjectTypeGuids.Select(ptg => ptg.ToString());
+                        var allReadProjectTypeGuids = MSBuildHelpers.GetAllProjectTypeGuids(root);
+                        Console.WriteLine($"{root.FullPath} is an unsupported project type. Not all project type guids are supported.");
+                        PrintGuidMessage(allSupportedProjectTypeGuids, allReadProjectTypeGuids);
+                        return false;
+                    }
+                    else
+                    {
+                        return true;
+                    }
                 }
 
             static void PrintGuidMessage(IEnumerable<string> allSupportedProjectTypeGuids, IEnumerable<string> allReadProjectTypeGuids)