Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

mirror msbuild assembly load logic #197

Merged

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Jan 15, 2020

fixes #169

Unverified

The committer email address is not verified.
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you run the skipped legacy F# tests with this change?

@jmarolf
Copy link
Contributor Author

jmarolf commented Jan 15, 2020

What happens if you run the skipped legacy F# tests with this change?

They fail same as they always have :) I'll do some end-to-end testing before merging this

@cartermp
Copy link
Contributor

Man why does msbuild hate those dang old projects

@jmarolf
Copy link
Contributor Author

jmarolf commented Jan 15, 2020

F# legacy continues to work as expected

@jmarolf jmarolf merged commit fa3e408 into dotnet:master Jan 15, 2020
@jmarolf jmarolf deleted the bugfix/allow-upstream-versions-in-type-loading branch January 15, 2020 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundException trying to load assembly System.Configuration.ConfigurationManager
2 participants