Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Allow conversion of projects with unrecognized imports #378

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

mjrousos
Copy link
Member

This updates try-convert's response to unrecognized imports. Rather than failing the conversion, the conversion proceeds and the unrecognized imports are left unchanged.

If the imported props or targets file is not one recognized as an allowable import, the user is given a message warning that the import may not work with the converted project file.

Fixes #370

@mjrousos
Copy link
Member Author

@cartermp, here's the imports update we talked about a few days ago. Turns out it was easier than I expected to get the desired behavior because the project root element still has the old imports and there's an explicit converter step to remove them - so I just updated that.

@ardalis
Copy link

ardalis commented Feb 22, 2021

Would love to see a release of this soon! Thanks!

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp merged commit 2a955fb into dotnet:master Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow enabling support for custom imports
3 participants