Skip to content

Commit

Permalink
Merge pull request #6232 from dotnet/merges/release-to-main
Browse files Browse the repository at this point in the history
Merge release to main
  • Loading branch information
dotnet-bot authored Aug 26, 2023
2 parents 002c58d + f4b7db4 commit 68ef163
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,24 @@
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)

## Latest
* Fix UriFormatException during dotnet SDK resolution when symlinks are involved (PR: [#6230](https://github.com/dotnet/vscode-csharp/pull/6230))

## 2.0.413
* Update Roslyn version (PR: [#6192](https://github.com/dotnet/vscode-csharp/pull/6192))
* Add support for compilation end diagnostics (PR: [#69541](https://github.com/dotnet/roslyn/pull/69541))
* Include CodeLens on more types and members (PR: [#69608](https://github.com/dotnet/roslyn/pull/69608))
* Improve performance when computing colorization (PR: [#69496](https://github.com/dotnet/roslyn/pull/69496))
* Fix dotnet resolver returning incorrect runtime in certain scenarios (PR: [#6180](https://github.com/dotnet/vscode-csharp/pull/6180))
* Fix issue resolving .NET 7 runtimes from path (PR: [#6175](https://github.com/dotnet/vscode-csharp/pull/6175))
* Fix URI issue when loading Razor files (PR: [#6168](https://github.com/dotnet/vscode-csharp/pull/6168))
* Bump Razor to 7.0.0-preview.23417.3 (PR: [#6165](https://github.com/dotnet/vscode-csharp/pull/6165))
* Fix various textDocument/foldingRange issues (PR: [#9134](https://github.com/dotnet/razor/pull/9134))
* Clarify dotnet path option description (PR: [#6164](https://github.com/dotnet/vscode-csharp/pull/6164))
* Handle multiple dotnet on path and symlinks (PR: [#6152](https://github.com/dotnet/vscode-csharp/pull/6152))
* Localize Roslyn options (PR: [#6136](https://github.com/dotnet/vscode-csharp/pull/6136))
* Show a prompt if we have more than one solution file (PR: [#6132](https://github.com/dotnet/vscode-csharp/pull/6132))

## 2.0.376
* Update Roslyn (PR: [#6131](https://github.com/dotnet/vscode-csharp/pull/6131))
* Only show toast for project load failures (PR: [#69494](https://github.com/dotnet/roslyn/pull/69494))
* Fix enter inserting /// on the incorrect line in documentation comments (PR: [#6130](https://github.com/dotnet/vscode-csharp/pull/6130))
Expand Down
10 changes: 2 additions & 8 deletions src/lsptoolshost/dotnetRuntimeExtensionResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { CSharpExtensionId } from '../constants/csharpExtensionId';
import { promisify } from 'util';
import { exec } from 'child_process';
import { getDotnetInfo } from '../shared/utils/getDotnetInfo';
import { readFile, readlink } from 'fs/promises';
import { readFile, realpath } from 'fs/promises';

export const DotNetRuntimeVersion = '7.0';

Expand Down Expand Up @@ -183,13 +183,7 @@ export class DotnetRuntimeExtensionResolver implements IHostExecutableResolver {

// If dotnet is just a symlink, resolve it to the actual executable so
// callers will be able to get the actual directory containing the exe.
try {
const targetPath = await readlink(path);
return targetPath;
} catch {
// Not a symlink.
return path;
}
return await realpath(path);
} catch (e) {
this.channel.appendLine(
'Failed to find dotnet info from path, falling back to acquire runtime via ms-dotnettools.vscode-dotnet-runtime'
Expand Down

0 comments on commit 68ef163

Please sign in to comment.