Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG note for omnisharp.minFindSymbolsFilterLength and omnisharp… #2553

Merged

Conversation

dmgonch
Copy link
Contributor

@dmgonch dmgonch commented Sep 23, 2018

@akshita31 : updated CHANGELOG as per your comment #2487 (comment)

@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #2553 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   65.26%   65.09%   -0.17%     
==========================================
  Files          97       97              
  Lines        4226     4226              
  Branches      605      605              
==========================================
- Hits         2758     2751       -7     
- Misses       1296     1302       +6     
- Partials      172      173       +1
Flag Coverage Δ
#integration 52.92% <ø> (-0.17%) ⬇️
#unit 84.76% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/features/documentation.ts 38.09% <0%> (-9.53%) ⬇️
src/features/completionItemProvider.ts 78.78% <0%> (-9.1%) ⬇️
src/features/diagnosticsProvider.ts 75.36% <0%> (+0.72%) ⬆️
src/features/codeLensProvider.ts 48.54% <0%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6c4c9...234774b. Read the comment docs.

@dmgonch
Copy link
Contributor Author

dmgonch commented Sep 27, 2018

@akshita31 is this ready to be pulled into master?

@akshita31 akshita31 merged commit 8561934 into dotnet:master Oct 1, 2018
@akshita31
Copy link
Contributor

Merged. Also @dmgonch we should add the changelog to omnisharp-roslyn as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants