-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #4016
Fix typo #4016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4016 +/- ##
=======================================
Coverage 85.99% 85.99%
=======================================
Files 60 60
Lines 1856 1856
Branches 214 214
=======================================
Hits 1596 1596
Misses 200 200
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, wait. Looking more - you don't want the assets.ts part of the change. That code already checks for the correctly named option. The line you changed is to check for the misspelled version.
@gregg-miskelly Ah got it! |
LGTM. Thanks for the PR! @JoeRobich do you want to take a look before we merge? |
Fixes #4004