Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #4016

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Fix typo #4016

merged 3 commits into from
Aug 25, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 24, 2020

Fixes #4004

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #4016 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4016   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1856     1856           
  Branches      214      214           
=======================================
  Hits         1596     1596           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6608b73...914b1f2. Read the comment docs.

Copy link
Contributor

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, wait. Looking more - you don't want the assets.ts part of the change. That code already checks for the correctly named option. The line you changed is to check for the misspelled version.

@Youssef1313
Copy link
Member Author

@gregg-miskelly Ah got it!
That change was messing up the backcompat. I'll revert it

@gregg-miskelly
Copy link
Contributor

LGTM. Thanks for the PR! @JoeRobich do you want to take a look before we merge?

@JoeRobich
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spelling for supressBuildAssetsNotification in Preferences
3 participants