Route razor/simplifyMethod to Roslyn #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonitra
changed the title
lonitra
force-pushed
the
razorsimplifyhandler
branch
from
2b421cf to
9f6bdcc
Compare
lonitra
force-pushed
the
razorsimplifyhandler
branch
from
96cf203 to
abed43e
Compare
lonitra
force-pushed
the
razorsimplifyhandler
branch
from
d9b7b49 to
aee3db1
Compare
davidwengier
approved these changes
Aug 9, 2023
ryzngard
approved these changes
Aug 9, 2023
davidwengier
reviewed
Aug 9, 2023
| import { TextEdit } from 'vscode-html-languageservice'; | ||
|
|
||
| export interface SerializableDelegatedSimplifyMethodParams { | ||
| identifier: SerializableTextDocumentIdentifierAndVersion; |
There was a problem hiding this comment.
I forgot we changed to use TextDocumentIdentifierAndVersion. @ryzngard do we need to update other types in the extension to this, or is the serialization compatible with whatever they currently have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to route LSP call
razor/simplifyMethodto Roslyn'sroslyn/simplifyMethod(new LSP method added by dotnet/roslyn#69323) so that 'Generate EventHandler' code action will behave the same as VS and will generate an event handler with the simplified type names.It also bumps the razor/roslyn server versions to include changes dotnet/razor#9070 and dotnet/roslyn#69323