Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for code lens enable/disable options to roslyn LSP #6001

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Add support for code lens enable/disable options to roslyn LSP #6001

merged 4 commits into from
Aug 5, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 3, 2023 •
edited
Loading

Resolves #5809

Requires server side PR to go in and be updated in this PR.

Server side PR - dotnet/roslyn#69352

@dibarbet dibarbet requested a review from a team as a code owner August 3, 2023 01:08
@dibarbet dibarbet mentioned this pull request Aug 3, 2023
Merged
@dibarbet dibarbet force-pushed the respect_codelens_options branch from b212407 to 2742fe7 Compare August 3, 2023 01:39
@dibarbet dibarbet force-pushed the respect_codelens_options branch from 2742fe7 to 47fe006 Compare August 3, 2023 02:05
@Cosifne
Copy link
Member

Cosifne commented Aug 4, 2023

Need a test in this file https://github.com/dotnet/vscode-csharp/blob/main/test/unitTests/lspToolHost/configurationMiddleware.test.ts

@dibarbet dibarbet enabled auto-merge August 5, 2023 00:03
@dibarbet dibarbet merged commit 0c90e60 into dotnet:main Aug 5, 2023
@dibarbet dibarbet deleted the respect_codelens_options branch August 5, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosifne Cosifne Cosifne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not disable Reference Code Lens
2 participants
@dibarbet @Cosifne