Add option to disable devkit #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Sep 18, 2023
package.json
Outdated
| @@ -1169,6 +1169,12 @@ | |||
| "default": null, | |||
| "description": "Sets a path where MSBuild binary logs are written to when loading projects, to help diagnose loading errors." | |||
| }, | |||
| "dotnet.loadProjectsWithCSharpExtension": { | |||
| "scope": "machine-overridable", | |||
There was a problem hiding this comment.
Unfortunately this doesn't remove it from user settings. I saw no way to actually remove it from user settings :(. Might be a limitation we have to live with.
There was a problem hiding this comment.
Hmm, does this work?
resource - Resource settings, which apply to files and folders, and can be configured in all settings levels, even folder settings.
There was a problem hiding this comment.
Resource allows user settings as well. However it seemed slightly more appropriate
dibarbet
force-pushed
the
add_devkit_disabled_option
branch
from
28e2485 to
bf8b811
Compare
jasonmalinowski
approved these changes
Sep 19, 2023
package.nls.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "configuration.dotnet.server.waitForDebugger": "Passes the --debug flag when launching the server to allow a debugger to be attached. (Previously `omnisharp.waitForDebugger`)", | |||
| "configuration.dotnet.server.trace": "Sets the logging level for the language server", | |||
| "configuration.dotnet.server.extensionPaths": "Override for path to language server --extension arguments", | |||
| "configuration.dotnet.preferCSharpExtension": "Forces projects to load with the C# extension only. This can be useful when using legacy project types that are not supported by the C# Dev Kit. (Requires window reload)", | |||
There was a problem hiding this comment.
Should there be a "the" before "C# Dev Kit" not?
There was a problem hiding this comment.
There shouldn't be a "the" before CDK.
mikadumont
reviewed
Sep 19, 2023
dibarbet
commented
Sep 19, 2023
dibarbet
added a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Sep 28, 2023
Add option to disable devkit
dibarbet
added a commit
to dibarbet/vscode-csharp
that referenced
this pull request
Sep 28, 2023
Add option to disable devkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.