Update filename to use for project info #6447
Conversation
|
Does this require a razor update? Or can this go in standalone? |
|
No Razor update needed, but needs to go in at the same time as a Roslyn update that includes Phil's PR |
|
Approved, but we should probably wait until the Roslyn side PR comes through so that we write & read the same file. |
|
Tempted to clean this up and move the logic all to Razor, like it says in the comment |
|
Actually, even if we consolidate all of the logic into the Razor repo, we'd still need dual insertions to change it because the dependency is backwards here, and Roslyn references Razor. Maybe the real cleanup is to flip that, and have Razor deploy a DLL, and pass it to the language server as an extension. For now I'll merge the Roslyn PR and update this one with a Roslyn bump. |
davidwengier
force-pushed
the
UpdateFilename
branch
from
a2546bf to
f6dad24
Compare
| * Update Roslyn version to 4.9.0-1.23502.8 (PR: [#6447](https://github.com/dotnet/vscode-csharp/pull/6447)) | ||
| * Update Razor project configuration file name (PR: [#70156](https://github.com/dotnet/roslyn/pull/70156)) | ||
|
|
||
| ## 2.5.? |
There was a problem hiding this comment.
@dibarbet not sure what the normal process here is. Will it be 2.5.0? .1?
There was a problem hiding this comment.
it is most likely going to be 2.5.30 unless we have to re-spin for some reason (you can check the release branch build number). You can use that, or ? and we'll update it when we actually release.
There was a problem hiding this comment.
I'll leave it then. More likely to notice it needs to be updated if its a question mark
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Finally got the builds to pass, and whilst Windows Sandbox died on me 3 times, I validated on a DevBox and razor seems to continue working fine. My machine is haunted, but that seems unrelated. |
Copying Phil in dotnet/roslyn#70156