Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project Context status item #7321

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jul 9, 2024

Adds a status item to display the project context of the active C# file.

For files in the open workspace:
image

For files in the misc workspace:
image

When running with DevKit:
image

@JoeRobich JoeRobich requested a review from a team as a code owner July 9, 2024 23:15
src/lsptoolshost/languageStatusBar.ts Outdated Show resolved Hide resolved
languageServerOptions.documentSelector
);
item.name = vscode.l10n.t('C# Project Context Status');
item.detail = vscode.l10n.t('Project Context');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of 'Project Context' in the right hand part of the status bar item, maybe 'Active File Context'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change to that. @mikadumont is there a name you prefer here?

src/lsptoolshost/services/projectContextService.ts Outdated Show resolved Hide resolved
src/lsptoolshost/languageStatusBar.ts Outdated Show resolved Hide resolved
@JoeRobich JoeRobich force-pushed the dev/jorobich/project-context-item branch from d97da14 to 077928f Compare July 10, 2024 08:01
@JoeRobich JoeRobich force-pushed the dev/jorobich/project-context-item branch from 077928f to 39cb053 Compare July 10, 2024 08:10
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments, but nothing blocking. Would be great to get this in for next weeks release!

src/lsptoolshost/services/projectContextService.ts Outdated Show resolved Hide resolved
@JoeRobich JoeRobich merged commit 09d8fd9 into main Jul 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants