Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the workspace status bar when the server is stopped. #7352

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

JoeRobich
Copy link
Member

  • Sets the workspace status item to the Warning state to display an indicator that there has been an issue.
  • Provides easy access to restart the LSP server.
Server.Status.mp4

- Sets the workspace status item to the Warning state to display an indicator that there has been an issue.
- Provides easy access to restart the LSP server.
@JoeRobich JoeRobich requested a review from a team as a code owner July 15, 2024 23:41
@JoeRobich JoeRobich requested a review from dibarbet July 15, 2024 23:42
private readonly _emptyProjectContext: VSProjectContext = {
_vs_id: '',
_vs_kind: '',
_vs_label: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the empty strings needed for anything? Might prefer to send undefined if not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do use it to blank out the Project Context item text. Going to leave as is for now and we can revisit if necessary.

@JoeRobich JoeRobich merged commit 353ebcf into main Jul 16, 2024
13 checks passed
@JoeRobich JoeRobich deleted the dev/jorobich/server-status branch October 8, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants