Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note to update GetClrDbg.sh in MIEngine. #751

Merged
merged 2 commits into from
Sep 8, 2016

Conversation

rajkumar42
Copy link
Contributor

No description provided.

@rajkumar42
Copy link
Contributor Author

@gregg-miskelly @caslan

@gregg-miskelly
Copy link
Contributor

LGTM

@@ -30,6 +30,7 @@ export function getCurrentPlatform() {
else if (process.platform === 'linux') {
// Get the text of /etc/os-release to discover which Linux distribution we're running on.
// For details: https://www.freedesktop.org/software/systemd/man/os-release.html
// When any distro or version is added, please update GetClrDbg.sh in MIEngine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Microsoft/MIEngine/blob/master/scripts/GetClrDbg.sh

Do we want to put some text here that makes it clear that we don't necessarily expect community members to do this? (just Microsoft employees)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants