Fix Linux Update #1874
Merged
Fix Linux Update #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this bug could exist with the current tests, need to prevent this bug.
MiYanni
approved these changes
Jul 12, 2024
| @@ -17,6 +17,10 @@ Performance improvements. | |||
|
|
|||
| Fixes a bug with apt-get lock holding (status 100) on Linux with package management. | |||
|
|
|||
| Adds acquireStatus support for ASP.NET runtime installs. | |||
|
|
|||
| Other bug fixes. | |||
There was a problem hiding this comment.
nit: Maybe Minor bug fixes. would be a bit more descriptive?
There was a problem hiding this comment.
I think that is a better way of putting it. :)
There was a problem hiding this comment.
It got auto-merged though so I will fix it next time 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very simple additional test for the acquireStatus API earlier, that I forgot to push while I wasn't feeling well.
This also fixes an issue with update, the || operator does not work in this context and itll treat it as an optional flag thats invalid. It was hacky to do anyway, so I just got rid of it.