Interpret Installer Exit Codes #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will give the user more actionable items, and also increase the chances the post a log so we can help them if something goes wrong and understand the issue better.
joeloff
reviewed
Jul 15, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
nagilson
commented
Jul 15, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
nagilson
commented
Jul 15, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
nagilson
commented
Jul 15, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
nagilson
commented
Jul 15, 2024
vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will give the user more actionable items, and also increase the chances the post a log so we can help them if something goes wrong and understand the issue better.
Error code interpretation comes from https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--1300-1699- pages, the installer source code, and joeloff (area expert)