Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running the sample extension as a .vsix #632

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sample/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
"onCommand:sample.dotnet-sdk.uninstallAll",
"onCommand:sample.dotnet-sdk.showAcquisitionLog"
],
"extensionDependencies": [
"ms-dotnettools.vscode-dotnet-runtime",
"ms-dotnettools.vscode-dotnet-sdk"
],
"main": "./out/extension.js",
"contributes": {
"commands": [
Expand Down
9 changes: 5 additions & 4 deletions sample/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ import * as cp from 'child_process';
import * as path from 'path';
import * as vscode from 'vscode';
import { IDotnetAcquireResult } from 'vscode-dotnet-runtime-library';
import * as runtimeExtension from 'vscode-dotnet-runtime';
import * as sdkExtension from 'vscode-dotnet-sdk';
// import * as runtimeExtension from 'vscode-dotnet-runtime';
// import * as sdkExtension from 'vscode-dotnet-sdk';

export function activate(context: vscode.ExtensionContext) {

// --------------------------------------------------------------------------

/*

***** See the package.json, I followed the instructions here: ****
NOTE: This sample should technically have the following in its package.json:

"extensionDependencies": [
Expand All @@ -31,8 +32,8 @@ export function activate(context: vscode.ExtensionContext) {
*/

const requestingExtensionId = 'ms-dotnettools.sample-extension';
runtimeExtension.activate(context);
sdkExtension.activate(context);
// runtimeExtension.activate(context);
// sdkExtension.activate(context);

// --------------------------------------------------------------------------

Expand Down