Skip to content

Commit

Permalink
Rebase and resolve conflicts.
Browse files Browse the repository at this point in the history
  • Loading branch information
imcarolwang committed Mar 21, 2024
1 parent cda277c commit 5c61c9f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
7 changes: 1 addition & 6 deletions src/dotnet-svcutil/lib/src/Shared/MSBuildProj.cs
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,9 @@ public static async Task<MSBuildProj> ParseAsync(string projectText, string proj
if (targetFrameworksElements.Count() > 0)
{
var targetFrameworks = targetFrameworksElements.Last().Value;
if (targetFrameworks.ToString().StartsWith("$"))
{
targetFrameworks = GetValueFromDirBuildProps(targetFrameworks, msbuildProj.DirectoryPath);
}

foreach (var targetFx in targetFrameworks.Split(new char[] { ';' }, StringSplitOptions.RemoveEmptyEntries).Select(p => p.Trim()))
{
if (!string.IsNullOrWhiteSpace(targetFx))
if (!string.IsNullOrEmpty(targetFx) && !targetFx.ToString().StartsWith("$"))
{
msbuildProj._targetFrameworks.Add(targetFx);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
<PackageReference Include="System.ServiceModel.*", Version="N.N.N">
<PackageReference Include="System.ServiceModel.*", Version="N.N.N">
<PackageReference Include="System.ServiceModel.*", Version="N.N.N">
<PackageReference Include="System.Web.Services.Description", Version="N.N.N">
</ItemGroup>
</Project>

0 comments on commit 5c61c9f

Please sign in to comment.