Skip to content

Commit

Permalink
Remove System.Reflection.DispatchProxy reference (#5230)
Browse files Browse the repository at this point in the history
* Remove System.Reflection.DispatchProxy reference

System.Reflection.DispatchProxy has been absorbed into the shared framework since early .NETCoreApp days. The package hasn't been shipping for years now and shouldn't be referenced anymore.

* Update Versions.props

* Remove unused arcade properties (#5231)

* Remove unused arcade properties

* Update Version.Details.xml
  • Loading branch information
ViktorHofer authored Aug 10, 2023
1 parent 81e9a15 commit f339387
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
8 changes: 0 additions & 8 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.SignTool" Version="8.0.0-beta.23409.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="8.0.0-beta.23409.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenFacades" Version="8.0.0-beta.23409.5">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>bebd2de1988036b47ecefc7e72b66ce2f403e43d</Sha>
Expand Down
4 changes: 0 additions & 4 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,11 @@
</PropertyGroup>
<!-- Arcade dependencies -->
<PropertyGroup>
<MicrosoftDotNetArcadeSdkPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetArcadeSdkPackageVersion>
<MicrosoftDotNetHelixSdkPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetHelixSdkPackageVersion>
<MicrosoftDotNetGenFacadesPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetGenFacadesPackageVersion>
<MicrosoftDotNetXUnitExtensionsPackageVersion>8.0.0-beta.23409.5</MicrosoftDotNetXUnitExtensionsPackageVersion>
<MicrosoftDotNetSignToolVersion>8.0.0-beta.23409.5</MicrosoftDotNetSignToolVersion>
</PropertyGroup>
<!-- CoreFx dependencies -->
<PropertyGroup>
<SystemReflectionDispatchProxyPackageVersion>4.7.1</SystemReflectionDispatchProxyPackageVersion>
<SystemSecurityCryptographyXmlPackageVersion>6.0.1</SystemSecurityCryptographyXmlPackageVersion>
<MicrosoftExtensionsObjectPoolVersion>6.0.16</MicrosoftExtensionsObjectPoolVersion>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<IsPackable>true</IsPackable>
<!-- Workaround for https://github.com/NuGet/NuGet.Client/pull/3016 -->
<NoWarn>$(NoWarn);NU5131</NoWarn>
<TargetFrameworks>net6.0</TargetFrameworks>
<TargetFramework>net6.0</TargetFramework>
<IsShipping>$(Ship_WcfPackages)</IsShipping>
<PackageDescription>Provides the common types used by all of the WCF libraries.</PackageDescription>
<IsPartialFacadeAssembly>true</IsPartialFacadeAssembly>
Expand All @@ -23,7 +23,6 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="System.Reflection.DispatchProxy" Version="$(SystemReflectionDispatchProxyPackageVersion)" />
<PackageReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlPackageVersion)" />
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="$(MicrosoftExtensionsObjectPoolVersion)" />
</ItemGroup>
Expand Down

0 comments on commit f339387

Please sign in to comment.