NegotiateStream_Tcp_With_Upn test throw platform not supported exception

[hongdai]

It throws as we currently do not support UpnObjectComparer:Equals in ClaimComparer.cs

if SUPPORTS_WINDOWSIDENTITY

    private class UpnObjectComparer : IEqualityComparer
    {
        bool IEqualityComparer.Equals(object obj1, object obj2)
        {
            throw ExceptionHelper.PlatformNotSupported();
        }

[roncain]

@hongdai -- can you provide instructions how you ran this and the stack trace? I see from code inspection what you mean, but it would be good to have repro steps to know when it is fixed. Also, is this related to #1235?

Also, FYI, this test was renamed to NegotiateStream_Tcp_With_SPN by me because it was using SPN, not UPN. Either the test name was wrong or the test itself was wrong. Do you know which? This is why repro steps would be valuable.

[roncain]

I think there is still some confusion around this issue. It claims to test UPN, but on examination was using SPN. I changed the name to match what the test did but left the test code unmodified. For this reason, I don't understand how the title of this issue points to the failure being related to UPN.

@hongdai -- could you clarify? Are we missing test coverage with TCP and UPN?

I believe PR #1502 should fix UPN issues at the same time it fixes #1454. But the test as written is not UPN.

[hongdai]

I have verified this issue is fixed by PR #1502 and enable the test disabled by this issue.