Fix UpnEndpointIdentity on UWP #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If WindowsIdentity isn't supported, then we can't | ||
| // retrieve the SecurityIdentifier's to compare so | ||
| // must return false | ||
| return false; |
There was a problem hiding this comment.
I guess this is going to be a necessary evil in order for UWP to work... we however need to clearly show this in the release notes.
|
LGTM |
| @@ -258,12 +255,36 @@ int IEqualityComparer.GetHashCode(object obj) | |||
| } | |||
| } | |||
|
|
|||
| #if SUPPORTS_WINDOWSIDENTITY | |||
| //#if SUPPORTS_WINDOWSIDENTITY | |||
|
LGTM. |
roncain
added a commit
to roncain/wcf
that referenced
this pull request
Sep 19, 2016
PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity. But 2 tests were still disabled by issue 10, so this PR just re-enables those tests. Both require manual setup to run, so we will not see them pass or fail in CI or VSO.
roncain
added a commit
to roncain/wcf
that referenced
this pull request
Sep 19, 2016
PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity. But 2 tests were still disabled by issue 10, so this PR just re-enables those tests. Both require manual setup to run, so we will not see them pass or fail in CI or VSO. These tests still fail in UWP and so remain disabled there.
mconnew
added a commit
to mconnew/wcf
that referenced
this pull request
Sep 21, 2016
Fix UpnEndpointIdentity on UWP Re-enable tests disabled by issue 10, except for NET Native. PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity. But 2 tests were still disabled by issue 10, so this PR just re-enables those tests. Both require manual setup to run, so we will not see them pass or fail in CI or VSO. These tests still fail in UWP and so remain disabled there.
mconnew
added a commit
to mconnew/wcf
that referenced
this pull request
Sep 22, 2016
Fix UpnEndpointIdentity on UWP Re-enable tests disabled by issue 10, except for NET Native. PR dotnet#1502 fixed issue dotnet#10 by implementing UpnEndpointIdentity. But 2 tests were still disabled by issue 10, so this PR just re-enables those tests. Both require manual setup to run, so we will not see them pass or fail in CI or VSO. These tests still fail in UWP and so remain disabled there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1454