Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root certificate is not considered valid on *nix #1347

Closed
roncain opened this issue Jul 1, 2016 · 6 comments
Closed

Root certificate is not considered valid on *nix #1347

roncain opened this issue Jul 1, 2016 · 6 comments
Assignees
@iamjasonp
Labels
bug This is a product bug. infrastructure Issues related to the build, packaging, testing or related areas.
Milestone
2016.08

Comments

@roncain
Copy link
Contributor

roncain commented Jul 1, 2016

The Infrastructure test that verifies the validity of the root certificate fails on *nix. It fails when we use FindBy on the X509Certificate2Collection and ask for only a valid cert.

Exception is:

MESSAGE:
Did not find valid certificate with thumbprint 737B995D0F2829DC37EEC32C01559F5EDEA6E94B in StoreName 'Root', StoreLocation 'CurrentUser'\nExpected: True\nActual: False
+++++++++++++++++++
STACK TRACE:
at SetupValidationTests.ValidateCertificate(X509Certificate2 certificate, StoreName storeName, StoreLocation storeLocation) at SetupValidationTests.Root_Certificate_Correctly_Installed()
@roncain roncain added infrastructure Issues related to the build, packaging, testing or related areas. bug This is a product bug. labels Jul 1, 2016
@roncain roncain mentioned this issue Jul 5, 2016
Merged
@roncain
Copy link
Contributor Author

roncain commented Jul 11, 2016

I'm closing this because it no longer repro's since we moved forward to latest package dependencies. The Infrastructure.Tests project has been verified to run properly on Ubuntu.

@roncain roncain closed this as completed Jul 11, 2016
roncain added a commit to roncain/wcf that referenced this issue Aug 15, 2016
@roncain
Reenable test disabled by dotnet#1347
59cc4c5 
Issue dotnet#1347 was closed but there was still a test being
skipped on *nix machines due to an IssueAttribute for it.

This PR removes the IssueAttribute to re-enable this test.
@roncain roncain mentioned this issue Aug 15, 2016
Merged
@roncain
Copy link
Contributor Author

roncain commented Aug 15, 2016

Re-opening because this is still failing in both VSO and CI.

@roncain roncain reopened this Aug 15, 2016
@zhenlan zhenlan added this to the 2016.08 milestone Aug 16, 2016
@iamjasonp
Copy link
Member

See https://github.com/dotnet/corefx/issues/10801

@iamjasonp
Copy link
Member

We're still waiting for a package versions update

@iamjasonp
Copy link
Member

The package versions are up to date - #1475 needs to be rebased and I think it should pass now. If it doesn't, it means that something in corefx is still not quite fixed...

roncain added a commit to roncain/wcf that referenced this issue Sep 13, 2016
@roncain
Reenable test disabled by dotnet#1347
a26844e 
Issue dotnet#1347 was closed but there was still a test being
skipped on *nix machines due to an IssueAttribute for it.

This PR removes the IssueAttribute to re-enable this test.
@iamjasonp iamjasonp mentioned this issue Sep 14, 2016
Closed
iamjasonp pushed a commit to iamjasonp/wcf that referenced this issue Sep 14, 2016
@roncain @iamjasonp
Reenable test disabled by dotnet#1347
90d7a00 
Issue dotnet#1347 was closed but there was still a test being
skipped on *nix machines due to an IssueAttribute for it.

This PR removes the IssueAttribute to re-enable this test.
iamjasonp pushed a commit to iamjasonp/wcf that referenced this issue Sep 14, 2016
@roncain @iamjasonp
Reenable test disabled by dotnet#1347
eafca39 
Issue dotnet#1347 was closed but there was still a test being
skipped on *nix machines due to an IssueAttribute for it.

This PR removes the IssueAttribute to re-enable this test.

Fixes dotnet#1347
roncain added a commit that referenced this issue Sep 14, 2016
@roncain
Merge pull request #1475 from roncain/enable-1347
7d2bbeb 
Reenable test disabled by #1347
@iamjasonp
Copy link
Member

Woot. fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamjasonp iamjasonp

Labels
bug This is a product bug. infrastructure Issues related to the build, packaging, testing or related areas.
Projects
None yet
Milestone
2016.08
Development

No branches or pull requests
3 participants
@iamjasonp @roncain @zhenlan