Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround scenarios failed by S.Security.Principal.WindowsIdentity.GetCurrent #1569

Closed
hongdai opened this issue Sep 28, 2016 · 1 comment
Closed

Workaround scenarios failed by S.Security.Principal.WindowsIdentity.GetCurrent #1569

hongdai opened this issue Sep 28, 2016 · 1 comment
Assignees
@hongdai
Labels
bug This is a product bug.
Milestone
2016.10

Comments

@hongdai
Copy link
Contributor

hongdai commented Sep 28, 2016 •
edited
Loading

This is to find out a workaround for issue #946. The affected tests are:

NegotiateStream_Http_Tests.NegotiateStream_Http_With_ExplicitSpn [FAIL]
NegotiateStream_Http_Tests.NegotiateStream_Http_AmbientCredentials [FAIL]
Https_ClientCredentialTypeTests.WindowsAuthentication_RoundTrips_Echo [FAIL]
@hongdai hongdai added the bug This is a product bug. label Sep 28, 2016
@hongdai hongdai mentioned this issue Oct 4, 2016
Closed
@zhenlan zhenlan added this to the 2016.10 milestone Oct 4, 2016
@hongdai
Copy link
Contributor Author

hongdai commented Oct 6, 2016

Update info:
From a quick look at the code, Looks like WindowsIdentity.GetCurrent() in this case is used to be part of keys in two caches below:
private volatile MruCache<string, string> _credentialHashCache;
private volatile MruCache<string, HttpClient> _httpClientCache;

It does not look like it's necessary. However, we'll need to come out a way to form a unique key.

@hongdai hongdai changed the title Tests use S.Security.Principal.WindowsIdentity.GetCurrent fail Workaround scenarios failed by S.Security.Principal.WindowsIdentity.GetCurrent Oct 6, 2016
hongdai added a commit to hongdai/wcf that referenced this issue Oct 10, 2016
@hongdai
Fix the issue that we use WindowsIdentity.Current on *NIX
24b28ea 
* We use try/catch to catch PlatformNotSupported exception
and use the same way to set default user on UWP.

Fix dotnet#1569
@hongdai hongdai mentioned this issue Oct 10, 2016
Merged
hongdai added a commit to hongdai/wcf that referenced this issue Oct 11, 2016
@hongdai
Fix the issue that we use WindowsIdentity.Current on *NIX
45cf690 
* We use try/catch to catch PlatformNotSupported exception
and use the same way to set default user on UWP.

Fix dotnet#1569
@zhenlan zhenlan mentioned this issue Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongdai hongdai

Labels
bug This is a product bug.
Projects
None yet
Milestone
2016.10
Development

No branches or pull requests
2 participants
@hongdai @zhenlan