Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port FullFx fix for SocketConnection sync/async timeout ignore problem. #3994

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Port FullFx fix for SocketConnection sync/async timeout ignore problem. #3994

merged 3 commits into from
Oct 30, 2019

Commits on Oct 30, 2019

  1. Port Full Framework fix for SocketConnection sync/async timeout ignor… 

    …e problem.

* Changeset 1615113 in VSTS.
    @StephenBonikowsky
    StephenBonikowsky committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    2302c93 View commit details
    Browse the repository at this point in the history

  2. Replaced entire SocketConnection class will .NetFx implementation. 

    * There were still many changes that needed to be made to work in Core, too many to name, best just to do a diff.
* One big one was the absence of tracing code.
    @StephenBonikowsky
    StephenBonikowsky committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    05582c4 View commit details
    Browse the repository at this point in the history

  3. Updating PR based on feedback. 

    * Reoved SR.Format where not needed.
* Added back a comment that was useful.
* Use '_socket' instead of the in param 'socket' once '_socket = socket'
    @StephenBonikowsky
    StephenBonikowsky committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    de6bf4f View commit details
    Browse the repository at this point in the history