Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore(). #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mconnew
reviewed
Apr 30, 2020
| @@ -5,6 +5,8 @@ | |||
| // ------------------------------------------------------------------------------ | |||
|
|
|||
|
|
|||
| using System.Xml; | |||
|
|
|||
There was a problem hiding this comment.
We don't add using statements, we fully qualify everything.
mconnew
reviewed
Apr 30, 2020
| @@ -227,4 +234,16 @@ public enum SecurityKeyType | |||
| AsymmetricKey, | |||
| BearerKey | |||
| } | |||
| public partial class GenericXmlSecurityKeyIdentifierClause : SecurityKeyIdentifierClause | |||
| { | |||
There was a problem hiding this comment.
You need to declare that the Matches method has been overridden otherwise someone deriving from this class might get wrong behavior if calling base.Matches(). You should probably add the ReferenceXml property too otherwise you can't get the XmlElement back out if you want to.
added Matches
mconnew
approved these changes
Apr 30, 2020
|
@mconnew thanks ! |
HongGit
pushed a commit
that referenced
this pull request
May 2, 2020
…). (#4247) * Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore().
HongGit
pushed a commit
that referenced
this pull request
May 5, 2020
…). (#4247) * Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore().
HongGit
pushed a commit
that referenced
this pull request
May 5, 2020
…). (#4247) * Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore().
HongGit
added a commit
that referenced
this pull request
May 5, 2020
* Add support for WS2007HttpBinding plus some cleanup * Expose LocalClientSecuritySettings.DetectReplays * Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore(). (#4247) * Exposing GenericXmlSecurityKeyIdentifierClause and virtual CloneCore(). Co-authored-by: Matt Connew <mconnew@microsoft.com> Co-authored-by: Mike Rousos <MikeRou@Microsoft.com> Co-authored-by: BrentSchmaltz <brentschmaltz@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing GenericXmlSecurityKeyIdentitfierClause is needed for WsFederationSecurityBinding effort as WsTrustChannelSecurityTokenProvider needs to set this clause type.
Exposing CloneCore() is needed so the derived WsTrustClientCredentails.CloneCore() will be called.