Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOTS cleanup on non Windows #4360

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Sep 9, 2020

With recent changes to improve performance on Windows by bringing back use of IO completion ports, a bug was introduced on non-Windows platforms where cleaning up an IOThreadScheduler resulted in an exception due to attempting to free a null overlapped.

@mconnew
Copy link
Member Author

mconnew commented Sep 10, 2020

The errors in the failure make absolutely no sense:

---ETW Trace for Test SecutityBindingElementTest.Property_DefaultAlgorithmSuite Begins---
SecutityBindingElementTest.Property_DefaultAlgorithmSuite: Throwing an exception. Source: System.ServiceModel 4.0.0.0. Exception details: System.ArgumentNullException: Value cannot be null. (Parameter 'tokenXml')
---ETW Trace for Test SecutityBindingElementTest.Property_DefaultAlgorithmSuite Ends---

    SecutityBindingElementTest.Property_DefaultAlgorithmSuite [FAIL]
      Assert.Equal() Failure
      Expected: Basic256
      Actual:   Basic256
      Stack Trace:
        /_/src/System.ServiceModel.Security/tests/ServiceModel/SecutityBindingElementTest.cs(36,0): at SecutityBindingElementTest.Property_DefaultAlgorithmSuite()
  Finished:    System.ServiceModel.Security.Tests

It's saying it failed because Basic256 doesn't equal Basic256. It's also picking up ETW exception trace from some completely different place. I'm going to rerun the failed test to see if that fixes it as this looks like a JIT issue.

@mconnew
Copy link
Member Author

mconnew commented Sep 10, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants