Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IOTS non windows condition in Cleanup #4451

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

richamo
Copy link
Contributor

@richamo richamo commented Nov 27, 2020

Fix #4449

@mconnew
Copy link
Member

mconnew commented Dec 15, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mconnew
Copy link
Member

mconnew commented Dec 16, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mconnew
Copy link
Member

mconnew commented Dec 16, 2020

I believe these tests are failing because this change is based off of an earlier point in master and the Federation tests were modified since then making the client tests from the source branch incompatible with the current head server side. This change won't have any effect on the failing tests. The same failure was seen in a different PR. When I rebased that PR, the same tests started passing. Once the current run completes, I'll merge.

@mconnew mconnew merged commit 685ea17 into dotnet:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net5.0 on non-windows System.ArgumentNullException at System.Threading.Overlapped.Free
2 participants