-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HttpTransportBindingElement with Proxy property to enable client to specify IWebProxy #4563
Conversation
fix dotnet#4561 Update HttpChannelFactory to use fully specified bindingElement.Proxy
add Proxy property cloning
Add Proxy defaults
@mconnew hi again! Sorry for annoying mentioning and pushing, Thanx in advance for response! |
src/System.Private.ServiceModel/src/System/ServiceModel/Channels/HttpChannelFactory.cs
Show resolved
Hide resolved
This won't make the Proxy property available to you as it's not added to the contract (in src\System.ServiceModel.Http\ref\System.ServiceModel.Http.cs). But we have a general policy of not exposing new api in patch releases so I don't know how to easily solve this for you. Would accessing that property using reflection with the knowledge that it will be added to the public contract in the next major release work for you? |
…ls/HttpChannelFactory.cs Co-authored-by: Matt Connew <mconnew@microsoft.com>
Thank you for decision and proposal: |
We have an implementation assembly/package (System.Private.ServiceModel) and contract packages (eg System.ServiceModel.Http). The contract package contains the reference assembly, this is the assembly you compile against. If the api isn't in the reference assembly, you can't use it in your code even if it's in the implementation assembly (System.Private.ServiceModel). We don't add new api's to contracts in patch releases which means you won't be able to compile against the api even if we ship an updated implementation assembly with it there. Which is why I was asking if you would be okay with using the api via reflection. Otherwise I'll need to look into seeing if an exception is possible. |
I appreciate your explanation. |
Hello, @mconnew , what is news? Thanx in advance... |
@dimalyshev, this change will be released in a preview release as it's new API. We're still working out when that will be, but it won't be any later than the Build conference that's happening next month. |
Fix #4562
this commit enables clients to configure binding with fully specified IWebProxy object: