Mtom fixes #5069
Merged
Mtom fixes #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
approved these changes
Mar 30, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is failing because writeMessageHeaders should only be false for Http (as it has its own HTTP headers). WebSockets don't have per-request headers which is why these headers are added to the body. I need to work out how to differentiate between them and try to do it without exposing new API. One option is to add a message property which specifies whether to write message headers, with it defaulting to true and Http specifying false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4831
Also exposes UserNameSecurityToken as without it you can't use the token returned from the SecurityTokenProvider when using UserName credentials.