Fix some tests that would fail when running under a non en-US culture #5268
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
fix-unit-tests-on-non-US-culture
branch
3 times, most recently
from
203c71f to
15f647b
Compare
Before this commit, two tests would fail with this error (FaultExceptionTest.Serializable_TDetail and FaultExceptionTest.Serializable_Default):
```
Xunit.Sdk.EqualException
Assert.Equal() Failure
↓ (pos 1259)
Expected: ···:text><a:xmlLang>en-US</a:xmlLang></a:FaultException.FaultRea···
Actual: ···:text><a:xmlLang>fr-CH</a:xmlLang></a:FaultException.FaultRea···
↑ (pos 1259)
```
Explicitly setting the expected culture with a `BeforeAfterTestAttribute` solves this issue.
mconnew
force-pushed
the
fix-unit-tests-on-non-US-culture
branch
from
15f647b to
18fed83
Compare
|
I just rebased your branch so that the latest tests will run. Sorry it took so long to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, two tests would fail with this error (FaultExceptionTest.Serializable_TDetail and FaultExceptionTest.Serializable_Default):
Explicitly setting the expected culture with a
BeforeAfterTestAttributesolves this issue.